Disable transparent ungzip and add decompress interceptor #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangmengyan95
force-pushed
the
wangmengyan.add_decompress_interceptor_when_we_have_external_interceptors
branch
from
79d0f96 to
6802178
Compare
There was a problem hiding this comment.
Comment somewhere why we set Content-Length and totalSize to -1?
|
Small nits, squash and LGTM |
wangmengyan95
force-pushed
the
wangmengyan.add_decompress_interceptor_when_we_have_external_interceptors
branch
from
6802178 to
01a30d5
Compare
wangmengyan95
added a commit
that referenced
this pull request
Aug 28, 2015
…interceptor_when_we_have_external_interceptors Disable transparent ungzip and add decompress interceptor
wangmengyan95
deleted the
wangmengyan.add_decompress_interceptor_when_we_have_external_interceptors
branch
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to expose the raw response(ungziped response) to developers, we need to disable the transparent ungzip for ApacheHttpClient and URLConnection and add a decompress interceptor at the beginning of the interceptor list manually.
For OkHttp, since we can not disable the transparent ungzip, we will handle it separately.